-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Capture volunteers from the registration system #6605
Conversation
ietf/api/views.py
Outdated
now = datetime.datetime.now() | ||
month = now.month | ||
year = now.year | ||
if month > 7: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining this if statement would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment
ietf/api/views.py
Outdated
# registrants for the fall meeting will be volunteering for the | ||
# following year's nomcom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true for the summer meeting too (the nomcom selection process is run by then usually).
Instead I think we should discuss when the registration system should offer volunteering for nomcom - it may only want to do so only for the spring meeting. Or only if there is a nomcom configured that is accepting volunteers (and we can make the assumption that there would never be two nomcoms accepting volunteers at the same time.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline - I want to confirm that it's ok to have bogus timestamps on existing Volunteer
records and that the "time" field changing if the record is updated is what the field is meant to represent.
Tests failing - migrations need an update |
The base branch was changed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 285 285
Lines 40280 40291 +11
=======================================
+ Hits 35771 35782 +11
Misses 4509 4509 ☔ View full report in Codecov by Sentry. |
No description provided.